Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ac990c068174c5571cde09377edc09c53991320e
https://github.com/WebKit/WebKit/commit/ac990c068174c5571cde09377edc09c53991320e
Author: Luke Warlow <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-nn-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-nn.html
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynn-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynn.html
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynyn-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynyn.html
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-nn-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-nn.html
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn.html
A
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynyn-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynyn.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/page/LocalDOMWindow.cpp
Log Message:
-----------
CloseWatcherManagers inside iframes aren't notified about user activation
https://bugs.webkit.org/show_bug.cgi?id=315510
Reviewed by Anne van Kesteren.
Per the HTML spec, user activation should propagate to the close watcher
managers of child windows.
This updates notifyActivated to do this, mirroring how transient user
activation is handled.
This can only really be tested via dialogs because CloseWatchers don't expose
their "open" state,
and popovers cannot be prevented from closing.
The existing tests for dialog are also updated to fix issues that caused
timeouts and flaky results.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-nn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-nn.html:
Copied from
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn.html.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynn.html:
Copied from
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn.html.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynyn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-cross-origin-ynyn.html:
Copied from
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn.html.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-nn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-nn.html:
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynn.html:
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynyn-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/close-watcher/iframes/dialog-same-origin-ynyn.html:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::updateActivationTimestampAndNotify):
(WebCore::LocalDOMWindow::notifyActivated):
Canonical link: https://commits.webkit.org/314884@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
