Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7aeb5ed5836e6fd06bca752f0ec6c491f8058e51
https://github.com/WebKit/WebKit/commit/7aeb5ed5836e6fd06bca752f0ec6c491f8058e51
Author: Luke Warlow <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/dom/nodes/moveBefore/selection-preserve-expected.txt
M
LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/nodes/moveBefore/selection-preserve-expected.txt
M Source/WebCore/dom/Document.cpp
Log Message:
-----------
moveBefore() needs to handle selections
https://bugs.webkit.org/show_bug.cgi?id=316302
Reviewed by Ryosuke Niwa.
This calls FrameSelection::nodeWillBeRemoved() from within
Document::nodeWillBeMoved().
This correctly resets the ContainsSelectionEndPoint state flag, which fixes
some crashes.
While the selection-preserve.html test itself now runs, it largely fails still,
but
this is also true in Firefox's implementation so will need further
investigations as it might
be the test itself that's broken.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/dom/nodes/moveBefore/selection-preserve-expected.txt:
*
LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/nodes/moveBefore/selection-preserve-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::nodeWillBeMoved):
Canonical link: https://commits.webkit.org/314898@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
