Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 441e3da20428b184716463ad2fd3683388cdb4a8
https://github.com/WebKit/WebKit/commit/441e3da20428b184716463ad2fd3683388cdb4a8
Author: Dan Hecht <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M Source/JavaScriptCore/heap/Heap.cpp
Log Message:
-----------
[JSC] Remove a misleading comment in Heap::runEndPhase and run
deleteUnmarkedCompiledCode with an unset AtomStringTable
https://bugs.webkit.org/show_bug.cgi?id=316713
rdar://179162306
Reviewed by Yusuke Suzuki.
This comment seems misleading in two ways, given the current code:
1. deleteUnmarkedCompiledCode doesn't seem to do anything that would
access the AtomStringTable.
2. The VM's AtomStringTable does not appear to ever be installed as
the collector thread's current AtomStringTable, so even if the above
call did access the atom string table, it would be the wrong table
when this code is run from the collector thread.
Let's also move this call into the scope where the current thread's
AtomStringTable is set to nullptr to verify both reasons.
* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::clearConcurrentRetainedDataIfPossible):
Canonical link: https://commits.webkit.org/314930@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
