Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 90b15daeda519ec18e6d968e20a8ab99544a9b4a
https://github.com/WebKit/WebKit/commit/90b15daeda519ec18e6d968e20a8ab99544a9b4a
Author: Sam Sneddon <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
Log Message:
-----------
[webkitpy] commits_for_upload should use path_to_module instead of __file__
https://bugs.webkit.org/show_bug.cgi?id=316264
Reviewed by Jonathan Bedard.
Prior to 234763@main, commits_for_upload relied on initialize_scm() to
discover the checkout root. Internally, initialize_scm() tried the cwd
first, then fell back to the script's directory via
path_to_module(__name__).
234763@main switched to local.Scm.from_path with a dirname(__file__)
fallback, which tried cwd then dirname(__file__). Since __file__ is a
real filesystem path, this escaped the MockHost abstraction, causing
local.Scm.from_path to walk the real directory tree and register real
Tracker instances.
This restores the old fallback pattern, avoiding the trap of the real
filesystem path.
We now need to catch the resulting OSError so tests with mock
filesystems don't crash when the path doesn't resolve to a checkout.
* Tools/Scripts/webkitpy/port/base.py:
(Port.commits_for_upload)
Canonical link: https://commits.webkit.org/314949@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
