Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 758fa8af026f31b0a74513086c869579b38c90be
https://github.com/WebKit/WebKit/commit/758fa8af026f31b0a74513086c869579b38c90be
Author: Basuke Suzuki <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
M Source/cmake/OptionsIOS.cmake
M Source/cmake/OptionsMac.cmake
Log Message:
-----------
[cmake] Make ENABLE_BACK_FORWARD_LIST_SWIFT configurable
https://bugs.webkit.org/show_bug.cgi?id=316838
rdar://179279702
Reviewed by Adrian Taylor.
Source/cmake/OptionsMac.cmake and Source/cmake/OptionsIOS.cmake forced
ENABLE_BACK_FORWARD_LIST_SWIFT via SET_AND_EXPOSE_TO_BUILD called after
WEBKIT_OPTION_END(). SET_AND_EXPOSE_TO_BUILD performs an unconditional set(),
which overrides whatever value the user passed on the cmake command line, so
-DENABLE_BACK_FORWARD_LIST_SWIFT=<...> had no effect on either port.
Move the assignment inside the WEBKIT_OPTION_BEGIN()/END() block and use
WEBKIT_OPTION_DEFAULT_PORT_VALUE on both ports. Defaults are unchanged (Mac:
ON, iOS: OFF), but the value now flows through option() and can be overridden
on the cmake command line.
Mac: useful for troubleshooting Swift back/forward list issues or comparing
against the legacy C++ implementation.
iOS: the existing FIXME (https://bugs.webkit.org/show_bug.cgi?id=312083) still
explains why ON is not yet supported (WebCore_Private Swift module not yet
available); the override path simply unblocks future experimentation.
No new tests (build configuration only; verified locally that the default Mac
build still produces the Swift-enabled WebKit framework, and that
-DENABLE_BACK_FORWARD_LIST_SWIFT=OFF reconfigures and links a Swift-disabled
framework).
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsIOS.cmake:
Canonical link: https://commits.webkit.org/314965@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
