Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9b9a6b01499fb3a138593c7a476744d421e3952b
https://github.com/WebKit/WebKit/commit/9b9a6b01499fb3a138593c7a476744d421e3952b
Author: Etienne Segonzac <[email protected]>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
A
LayoutTests/model-element/gpup/stagemode-orbit-resumes-after-reload-expected.txt
A LayoutTests/model-element/gpup/stagemode-orbit-resumes-after-reload.html
M Source/WebKit/Shared/Model/WKStageModeOrbitSimulator.h
M Source/WebKit/Shared/Model/WKStageModeOrbitSimulator.swift
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
WebModelPlayer should restore stageMode when reloaded
https://bugs.webkit.org/show_bug.cgi?id=316851
<rdar://179249565>
Reviewed by Mike Wyrzykowski.
Update `WebModelPlayer::reload` to restore the stageMode value too.
Test: model-element/gpup/stagemode-orbit-resumes-after-reload.html
*
LayoutTests/model-element/gpup/stagemode-orbit-resumes-after-reload-expected.txt:
Added.
* LayoutTests/model-element/gpup/stagemode-orbit-resumes-after-reload.html:
Added.
Introduce a new test covering this change. It's specific to the GPUP
implementation.
* Source/WebKit/Shared/Model/WKStageModeOrbitSimulator.h:
* Source/WebKit/Shared/Model/WKStageModeOrbitSimulator.swift:
(WKStageModeOrbitSimulator.setCurrentYaw(_:pitch:)):
Introduce a method to seed the WKStageModeOrbitSimulator with restored
pitch / yaw values.
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::handleMouseDown):
(WebKit::WebModelPlayer::reload):
Seed the `WKStageModeOrbitSimulator` with pitch / yaw values to avoid
jumps when orbiting a reloaded model.
Canonical link: https://commits.webkit.org/315026@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
