Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eae8df7857ad5b9a83f56d1d45eb427a38402f18
      
https://github.com/WebKit/WebKit/commit/eae8df7857ad5b9a83f56d1d45eb427a38402f18
  Author: Tadeu Zagallo <[email protected]>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/i32_conversion-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/u32_conversion-expected.txt
    M Source/WebGPU/WGSL/ConstantFunctions.h
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WebGPU] shader,execution,expression,unary,u32_conversion:* is failing
https://bugs.webkit.org/show_bug.cgi?id=316681
rdar://179133471

Reviewed by Mike Wyrzykowski.

There we 2 issues:
- The constant function did not handle the float to integer conversion correctly
- The runtime function was only called for scalars, but not for vectors.

This also fixes the i32_conversion tests.

* 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/i32_conversion-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/u32_conversion-expected.txt:
* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::StaticCast::cast):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/315047@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to