Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25f3ce5a5cc11d88871ef07762ce9a4874ab4003
https://github.com/WebKit/WebKit/commit/25f3ce5a5cc11d88871ef07762ce9a4874ab4003
Author: Anuj Panta <[email protected]>
Date: 2026-06-11 (Thu, 11 Jun 2026)
Changed paths:
A
LayoutTests/http/tests/site-isolation/inspector/dom/event-listeners-frame-target-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/dom/event-listeners-frame-target.html
A
LayoutTests/http/tests/site-isolation/inspector/dom/resources/event-listeners-frame.html
M Source/JavaScriptCore/inspector/protocol/DOM.json
M Source/WebCore/inspector/InspectorInstrumentation.cpp
M Source/WebCore/inspector/agents/frame/FrameDOMAgent.cpp
M Source/WebCore/inspector/agents/frame/FrameDOMAgent.h
M Source/WebCore/inspector/agents/frame/FrameDOMAgentStubs.cpp
M Source/WebInspectorUI/UserInterface/Models/DOMNode.js
Log Message:
-----------
Web Inspector: populate Event Listeners sidebar for cross-origin iframe nodes
(re)
https://bugs.webkit.org/show_bug.cgi?id=314761
rdar://177011541
Reviewed by Qianlang Chen.
Wires up the Event Listeners sidebar for cross-origin iframe nodes in the
Elements panel. Ports getEventListenersForNode and setEventListenerDisabled
from InspectorDOMAgent, skipping the debugger-breakpoint bits. Routes
isEventListenerDisabled through FrameDOMAgent so the per-listener disable
toggle is honored during event dispatch in the frame's process. Declares
the three commands with targetTypes ["frame", "page"] so FrameTarget exposes
them. Drops the {listeners: []} guard in DOMNode.getEventListeners and
routes through owningTarget + backendNodeId.
setAllowEditingUserAgentShadowTrees is backend storage only; the gate that
reads the flag lands with DOM editing in a follow-up. Relanding after revert.
Test: http/tests/site-isolation/inspector/dom/event-listeners-frame-target.html
*
LayoutTests/http/tests/site-isolation/inspector/dom/event-listeners-frame-target-expected.txt:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom/event-listeners-frame-target.html:
Added.
*
LayoutTests/http/tests/site-isolation/inspector/dom/resources/event-listeners-frame.html:
Added.
* Source/JavaScriptCore/inspector/protocol/DOM.json:
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::isEventListenerDisabledImpl):
* Source/WebCore/inspector/agents/frame/FrameDOMAgent.cpp:
(WebCore::FrameDOMAgent::reset):
(WebCore::FrameDOMAgent::setAllowEditingUserAgentShadowTrees):
(WebCore::FrameDOMAgent::getEventListenersForNode):
(WebCore::FrameDOMAgent::setEventListenerDisabled):
(WebCore::FrameDOMAgent::isEventListenerDisabled):
(WebCore::FrameDOMAgent::buildObjectForEventListener):
* Source/WebCore/inspector/agents/frame/FrameDOMAgent.h:
* Source/WebCore/inspector/agents/frame/FrameDOMAgentStubs.cpp:
(WebCore::FrameDOMAgent::getEventListenersForNode): Deleted.
(WebCore::FrameDOMAgent::setEventListenerDisabled): Deleted.
(WebCore::FrameDOMAgent::setAllowEditingUserAgentShadowTrees): Deleted.
* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.getEventListeners):
Canonical link: https://commits.webkit.org/315055@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
