Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 083f263204a7f4fa1168ce116eaf30cd8c1868b2
      
https://github.com/WebKit/WebKit/commit/083f263204a7f4fa1168ce116eaf30cd8c1868b2
  Author: Przemyslaw Gorszkowski <[email protected]>
  Date:   2026-06-12 (Fri, 12 Jun 2026)

  Changed paths:
    M LayoutTests/fast/dom/navigator-property-gc-after-frame-detach-expected.txt
    M LayoutTests/fast/dom/navigator-property-gc-after-frame-detach.html
    M Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp
    M Source/WebCore/Modules/mediacapabilities/MediaCapabilities.h
    M Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl
    M Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.cpp
    M Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.h
    M 
Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.cpp
    M 
Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.h

  Log Message:
  -----------
  navigator.mediaCapabilities wrapper should not become GC-collectable before 
its navigator object
https://bugs.webkit.org/show_bug.cgi?id=315684

Reviewed by Ryosuke Niwa.

navigator.mediaCapabilities wrapper should not become GC-collectable before its 
navigator object.
The MediaCapabilities interface is annotated [SameObject] in the spec:
https://www.w3.org/TR/media-capabilities/#idl-index
It means that navigator.mediaCapabilities must return the same object on every 
access.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1678

Original author: Andrzej Surdej (https://github.com/asurdej-comcast)

Updated existing LayoutTest with mediaCapabilities case.

* LayoutTests/fast/dom/navigator-property-gc-after-frame-detach-expected.txt:
* LayoutTests/fast/dom/navigator-property-gc-after-frame-detach.html:
* Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:
(WebCore::MediaCapabilities::MediaCapabilities):
(WebCore::MediaCapabilities::navigator):
* Source/WebCore/Modules/mediacapabilities/MediaCapabilities.h:
(WebCore::MediaCapabilities::create):
* Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl:
* Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.cpp:
(WebCore::NavigatorMediaCapabilities::NavigatorMediaCapabilities):
(WebCore::NavigatorMediaCapabilities::from):
* Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.h:
* Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.cpp:
(WebCore::WorkerNavigatorMediaCapabilities::WorkerNavigatorMediaCapabilities):
(WebCore::WorkerNavigatorMediaCapabilities::from):
* Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.h:

Canonical link: https://commits.webkit.org/315088@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to