Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b0c4b5139e34076a28ee6d9b59ba5cf0871e22a4
https://github.com/WebKit/WebKit/commit/b0c4b5139e34076a28ee6d9b59ba5cf0871e22a4
Author: Keith Miller <[email protected]>
Date: 2026-06-12 (Fri, 12 Jun 2026)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
Log Message:
-----------
[CMake] LowLevelInterpreterLib shouldn't serialize with the rest of JSC
https://bugs.webkit.org/show_bug.cgi?id=316869
rdar://179296313
Reviewed by Geoffrey Garen.
Every JavaScriptCore translation unit was waiting for LLIntAssembly.h
generation before it could begin compiling, even though only
LowLevelInterpreter.cpp uses the header.
The serialization came from two CMake behaviors combining:
1. LLIntAssembly.h was listed as a source of LowLevelInterpreterLib,
which put it into the target's compile-ordering phony.
2. Consuming the target as $<TARGET_OBJECTS:...> propagated that
phony as an order-only dependency to JavaScriptCore's compile-
ordering phony, which all of its unified sources transitively
depend on.
Instead of adding LowLevelInterpreterLib as a SOURCE link against the
object file as a PRIVATE_LIBRARY by name. LowLevelInterpreter.cpp.o
still has a direct file-level dependency on LLIntAssembly.h, but no
propagation reaches JavaScriptCore, so unified sources can compile in
parallel with offlineasm.
Canonical link: https://commits.webkit.org/315135@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
