Title: [115222] trunk
Revision
115222
Author
commit-qu...@webkit.org
Date
2012-04-25 10:04:04 -0700 (Wed, 25 Apr 2012)

Log Message

[EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
https://bugs.webkit.org/show_bug.cgi?id=83880

Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-04-25
Reviewed by Antonio Gomes.

Tools:

Add missing implementation addOriginAccessWhitelistEntry and
removeOriginAccessWhitelistEntry to EFL's LayoutTestController
in order to unskip tests which rely on this.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
and removeOriginAccessWhitelistEntry implementation.

* platform/efl/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (115221 => 115222)


--- trunk/LayoutTests/ChangeLog	2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/LayoutTests/ChangeLog	2012-04-25 17:04:04 UTC (rev 115222)
@@ -1,3 +1,15 @@
+2012-04-25  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
+
+        [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
+        https://bugs.webkit.org/show_bug.cgi?id=83880
+
+        Reviewed by Antonio Gomes.
+
+        Unskip test cases which rely on LayoutTestController's addOriginAccessWhitelistEntry
+        and removeOriginAccessWhitelistEntry implementation.
+
+        * platform/efl/Skipped:
+
 2012-04-25  Thiago Marcos P. Santos  <thiago.san...@intel.com>
 
         [EFL] Remove duplicated test expectations

Modified: trunk/LayoutTests/platform/efl/Skipped (115221 => 115222)


--- trunk/LayoutTests/platform/efl/Skipped	2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-04-25 17:04:04 UTC (rev 115222)
@@ -2119,7 +2119,6 @@
 http/tests/security/cross-origin-xsl-redirect-BLOCKED.html
 http/tests/security/drag-drop-same-unique-origin.html
 http/tests/security/frameNavigation/not-opener.html
-http/tests/security/local-image-from-remote-whitelisted.html
 http/tests/security/local-user-CSS-from-remote.html
 http/tests/security/mixedContent/insecure-image-in-main-frame.html
 http/tests/security/mixedContent/insecure-plugin-in-iframe.html
@@ -2156,11 +2155,6 @@
 http/tests/xmlhttprequest/cross-origin-no-authorization.html
 http/tests/xmlhttprequest/failed-auth.html
 http/tests/xmlhttprequest/logout.html
-http/tests/xmlhttprequest/origin-whitelisting-all.html
-http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
-http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
-http/tests/xmlhttprequest/origin-whitelisting-removal.html
-http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
 http/tests/xmlhttprequest/remember-bad-password.html
 http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
 http/tests/xmlviewer/extensions-api.html

Modified: trunk/Tools/ChangeLog (115221 => 115222)


--- trunk/Tools/ChangeLog	2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/Tools/ChangeLog	2012-04-25 17:04:04 UTC (rev 115222)
@@ -1,3 +1,18 @@
+2012-04-25  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
+
+        [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
+        https://bugs.webkit.org/show_bug.cgi?id=83880
+
+        Reviewed by Antonio Gomes.
+
+        Add missing implementation addOriginAccessWhitelistEntry and
+        removeOriginAccessWhitelistEntry to EFL's LayoutTestController
+        in order to unskip tests which rely on this.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::addOriginAccessWhitelistEntry):
+        (LayoutTestController::removeOriginAccessWhitelistEntry):
+
 2012-04-25  Thiago Marcos P. Santos  <thiago.san...@intel.com>
 
         [EFL] [DRT] Reset text zoom factor before running a test

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (115221 => 115222)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-25 16:46:59 UTC (rev 115221)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-25 17:04:04 UTC (rev 115222)
@@ -223,14 +223,22 @@
     notImplemented();
 }
 
-void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
+void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
 {
-    notImplemented();
+    WebCore::KURL kurl;
+    kurl.setProtocol(String(protocol->characters(), protocol->length()));
+    kurl.setHost(String(host->characters(), host->length()));
+
+    ewk_security_policy_whitelist_origin_add(sourceOrigin->ustring().utf8().data(), kurl.string().utf8().data(), includeSubdomains);
 }
 
-void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
+void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
 {
-    notImplemented();
+    WebCore::KURL kurl;
+    kurl.setProtocol(String(protocol->characters(), protocol->length()));
+    kurl.setHost(String(host->characters(), host->length()));
+
+    ewk_security_policy_whitelist_origin_del(sourceOrigin->ustring().utf8().data(), kurl.string().utf8().data(), includeSubdomains);
 }
 
 void LayoutTestController::setMainFrameIsFirstResponder(bool)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to