Title: [115230] trunk
Revision
115230
Author
commit-qu...@webkit.org
Date
2012-04-25 11:12:07 -0700 (Wed, 25 Apr 2012)

Log Message

Unreviewed, rolling out r115222.
http://trac.webkit.org/changeset/115222
https://bugs.webkit.org/show_bug.cgi?id=84874

Caused test regressions on the EFL build (Requested by rakuco
on #webkit).

Patch by Sheriff Bot <webkit.review....@gmail.com> on 2012-04-25

Tools:

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::addOriginAccessWhitelistEntry):
(LayoutTestController::removeOriginAccessWhitelistEntry):

LayoutTests:

* platform/efl/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (115229 => 115230)


--- trunk/LayoutTests/ChangeLog	2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/LayoutTests/ChangeLog	2012-04-25 18:12:07 UTC (rev 115230)
@@ -1,3 +1,14 @@
+2012-04-25  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r115222.
+        http://trac.webkit.org/changeset/115222
+        https://bugs.webkit.org/show_bug.cgi?id=84874
+
+        Caused test regressions on the EFL build (Requested by rakuco
+        on #webkit).
+
+        * platform/efl/Skipped:
+
 2012-04-24  Ryosuke Niwa  <rn...@webkit.org>
 
         REGRESSION(r112177): listStyleType CSS property gets converted into listStyle

Modified: trunk/LayoutTests/platform/efl/Skipped (115229 => 115230)


--- trunk/LayoutTests/platform/efl/Skipped	2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-04-25 18:12:07 UTC (rev 115230)
@@ -2119,6 +2119,7 @@
 http/tests/security/cross-origin-xsl-redirect-BLOCKED.html
 http/tests/security/drag-drop-same-unique-origin.html
 http/tests/security/frameNavigation/not-opener.html
+http/tests/security/local-image-from-remote-whitelisted.html
 http/tests/security/local-user-CSS-from-remote.html
 http/tests/security/mixedContent/insecure-image-in-main-frame.html
 http/tests/security/mixedContent/insecure-plugin-in-iframe.html
@@ -2155,6 +2156,11 @@
 http/tests/xmlhttprequest/cross-origin-no-authorization.html
 http/tests/xmlhttprequest/failed-auth.html
 http/tests/xmlhttprequest/logout.html
+http/tests/xmlhttprequest/origin-whitelisting-all.html
+http/tests/xmlhttprequest/origin-whitelisting-exact-match.html
+http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html
+http/tests/xmlhttprequest/origin-whitelisting-removal.html
+http/tests/xmlhttprequest/origin-whitelisting-subdomains.html
 http/tests/xmlhttprequest/remember-bad-password.html
 http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
 http/tests/xmlviewer/extensions-api.html

Modified: trunk/Tools/ChangeLog (115229 => 115230)


--- trunk/Tools/ChangeLog	2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/Tools/ChangeLog	2012-04-25 18:12:07 UTC (rev 115230)
@@ -1,3 +1,16 @@
+2012-04-25  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r115222.
+        http://trac.webkit.org/changeset/115222
+        https://bugs.webkit.org/show_bug.cgi?id=84874
+
+        Caused test regressions on the EFL build (Requested by rakuco
+        on #webkit).
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::addOriginAccessWhitelistEntry):
+        (LayoutTestController::removeOriginAccessWhitelistEntry):
+
 2012-04-25  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
 
         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (115229 => 115230)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-25 18:07:34 UTC (rev 115229)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-25 18:12:07 UTC (rev 115230)
@@ -223,22 +223,14 @@
     notImplemented();
 }
 
-void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
+void LayoutTestController::addOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
 {
-    WebCore::KURL kurl;
-    kurl.setProtocol(String(protocol->characters(), protocol->length()));
-    kurl.setHost(String(host->characters(), host->length()));
-
-    ewk_security_policy_whitelist_origin_add(sourceOrigin->ustring().utf8().data(), kurl.string().utf8().data(), includeSubdomains);
+    notImplemented();
 }
 
-void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef sourceOrigin, JSStringRef protocol, JSStringRef host, bool includeSubdomains)
+void LayoutTestController::removeOriginAccessWhitelistEntry(JSStringRef, JSStringRef, JSStringRef, bool)
 {
-    WebCore::KURL kurl;
-    kurl.setProtocol(String(protocol->characters(), protocol->length()));
-    kurl.setHost(String(host->characters(), host->length()));
-
-    ewk_security_policy_whitelist_origin_del(sourceOrigin->ustring().utf8().data(), kurl.string().utf8().data(), includeSubdomains);
+    notImplemented();
 }
 
 void LayoutTestController::setMainFrameIsFirstResponder(bool)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to