Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2396869a1715c1e06b0b3a9bb9644cd5271c20a
https://github.com/WebKit/WebKit/commit/f2396869a1715c1e06b0b3a9bb9644cd5271c20a
Author: Dana Estra <[email protected]>
Date: 2026-07-16 (Thu, 16 Jul 2026)
Changed paths:
A
LayoutTests/media/picture-in-picture/picture-in-picture-media-stream-frames-expected.txt
A
LayoutTests/media/picture-in-picture/picture-in-picture-media-stream-frames.html
M Source/WebCore/html/HTMLMediaElement.cpp
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
Log Message:
-----------
Picture-in-Picture stops updating MediaStream video frames
https://bugs.webkit.org/show_bug.cgi?id=319387
rdar://180740366
Reviewed by Jer Noble.
314324@main added "VisibleInFullscreen" and
"VisibleInPictureInPicture" to enum MediaPlayerViewportVisibility but
didn't update
MediaPlayerPrivateMediaStreamAVFObjC::setViewportVisibility
to know that these values indicate that m_isVisibleInViewPort should
be set to true.
Also, now that viewport visibility can change when the fullscreen mode changes,
we should call setViewportVisibility when the fullscreen mode changes to keep
m_isVisibleInViewPort up to date.
New test:
LayoutTests/media/picture-in-picture/picture-in-picture-media-stream-frames.html
*
LayoutTests/media/picture-in-picture/picture-in-picture-media-stream-frames-expected.txt:
Added.
*
LayoutTests/media/picture-in-picture/picture-in-picture-media-stream-frames.html:
Added.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setFullscreenMode):
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setViewportVisibility):
Canonical link:
https://flagged.apple.com:443/proxy?t2=DA5g4i5Ya4&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE3MzQ1QG1haW4=&emid=4e5379bc-c9be-44c7-9e47-3329de904f3a&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
