Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a70448e1bbd9e55645755168287fdfa2d8384b3
https://github.com/WebKit/WebKit/commit/9a70448e1bbd9e55645755168287fdfa2d8384b3
Author: Ryan Haddad <[email protected]>
Date: 2026-07-16 (Thu, 16 Jul 2026)
Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py
M
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py
Log Message:
-----------
[webkitbot] Revert failed with error "Failed to create bug: Login attempts
exhausted"
https://bugs.webkit.org/show_bug.cgi?id=318965
rdar://problem/181820853
Reviewed by Aakash Jain.
When git-webkit revert creates its tracking bug, the --reason is used verbatim
as the Bugzilla
summary. A reason longer than Bugzilla's 255-character summary results in a
HTTP 400 response,
which Tracker.create() teated as the same as no response and printed a
hard-coded "Login
attempts exhausted" fallback even though authentication had succeeded.
Distinguish "no response" from "a response with an error status" with more
explicit checks,
and cap the summary at Bugzilla's limit so an over-length reason no longer
fails. The full
reason is preserved in the bug description.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker): Add MAX_SUMMARY_LENGTH.
(Tracker.cc_radar): Check "response is None" / "response is not None" so a 4xx
response is
not mistaken for a missing response.
(Tracker.create): Ditto. Also surface the server's error message on failure,
and truncate the
summary to MAX_SUMMARY_LENGTH.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:
(Bugzilla._create): Return Bugzilla's HTTP 400 for an over-length summary.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
(TestBugzilla.test_create_surfaces_server_error): Added.
(TestBugzilla.test_create_truncates_summary): Added.
Canonical link: https://commits.webkit.org/317356@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
