Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b008d85bb026f03ac31665a9f99536906c88bf77
https://github.com/WebKit/WebKit/commit/b008d85bb026f03ac31665a9f99536906c88bf77
Author: Marcos Caceres <[email protected]>
Date: 2026-07-16 (Thu, 16 Jul 2026)
Changed paths:
M Tools/Scripts/analyze-safer-cpp
A Tools/Scripts/webkitpy/safer_cpp/analyze_safer_cpp_unittest.py
Log Message:
-----------
[SaferCPP] analyze-safer-cpp reports "OK" for files that fail to compile
https://bugs.webkit.org/show_bug.cgi?id=317931
rdar://181330433
Reviewed by Ryosuke Niwa.
analyze-safer-cpp ignored clang's exit code, and its diagnostic regex matches
"error:" but not "fatal error:", so a file that failed to compile was reported
as "OK" with a zero exit. On a configured-but-unbuilt compile_commands tree
(missing generated headers) every file "passes" without being analyzed.
Surface a non-zero clang exit with no parsed diagnostic as an error, printing
the file and clang's output, so a compile failure fails the run instead of
passing silently.
Canonical link: https://commits.webkit.org/317370@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
