Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85fdb55d1dce07e1db0f9c97ff1cdcddd95998d6
      
https://github.com/WebKit/WebKit/commit/85fdb55d1dce07e1db0f9c97ff1cdcddd95998d6
  Author: David Kilzer <[email protected]>
  Date:   2026-07-17 (Fri, 17 Jul 2026)

  Changed paths:
    M Source/WebKit/Configurations/Base.xcconfig
    A Source/WebKit/Scripts/IPCTestingHeaders-input.xcfilelist
    A Source/WebKit/Scripts/IPCTestingHeaders-output.xcfilelist
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Configurations/Base.xcconfig
    M Tools/TestWebKitAPI/Configurations/TestIPC.xcconfig
    M Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig

  Log Message:
  -----------
  [WebKit] Install IPC testing headers for TestWebKitAPI builds
<https://bugs.webkit.org/show_bug.cgi?id=315109>
<rdar://177445283>

Reviewed by Elliott Williams.

TestWebKitAPI's `TestIPC`, `TestWebKitAPI`, and `TestWebKitAPILibrary`
targets `#include` IPC and Shared testing headers using relative
search paths from `Tools/TestWebKitAPI` back into `Source/WebKit`.
Engineering Debug/Release builds find the headers locally in the
source tree, but Production builds compile against an installed SDK
that does not include the entire WebKit source tree, so the same
`#include` lines fail to resolve.  Install the headers from a single
source of truth so the `#include` style is identical for both build
types.

`Source/WebKit/Scripts/IPCTestingHeaders-input.xcfilelist` is the
canonical list of the WebKit IPC and Shared testing header paths,
including the three IPC code-generator outputs (`MessageNames.h`,
`GeneratedSerializers.h`, `PushClientConnectionMessages.h`).  A new
`Copy IPC Testing Headers` build phase copies each entry to the
paired `IPCTestingHeaders-output.xcfilelist` destination, which
resolves through a new `WK_IPC_TESTING_HEADERS_DEST_DIR` build
setting so engineering writes to `BUILT_PRODUCTS_DIR` and Production
writes to the SDK install location.  TestWebKitAPI's
`HEADER_SEARCH_PATHS` has the symmetric reader-side override so both
builds resolve the `#include` at the same logical name.  The phase
drives the existing `Source/WebKitLegacy/scripts/xcfilelist-copy.py`
-- the same script the header-migration phases already use -- rather
than adding a new copy script.

No new tests since this change is not directly testable.

* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/Scripts/IPCTestingHeaders-input.xcfilelist: Add.
* Source/WebKit/Scripts/IPCTestingHeaders-output.xcfilelist: Add.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestIPC.xcconfig:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig:

Canonical link: https://commits.webkit.org/317372@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to