Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c00be874bede417883bba68e6fb69ef2686a4103
https://github.com/WebKit/WebKit/commit/c00be874bede417883bba68e6fb69ef2686a4103
Author: Megan Gardner <[email protected]>
Date: 2026-07-17 (Fri, 17 Jul 2026)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/StyledMarkedText.cpp
Log Message:
-----------
[CSS Highlight API] ::highlight() does not apply text-shadow
https://bugs.webkit.org/show_bug.cgi?id=319634
rdar://182458208
Reviewed by Jessica Cheung.
::highlight() overlays were dropping text-shadow:
computeStyleForPseudoElementStyle copied the pseudo's background, fill, and
decoration styles but not its
shadow, and even once that was set, coalesceAdjacentWithSameRanges — which
merges the base and highlight segments covering the same range — carried over
everything but textShadow, so it got thrown away before paint. Fixed both by
setting style.textShadow from the pseudo style and propagating it from the
frontmost
highlight during coalescing (gated on the highlight name so a plain unshadowed
segment can't clobber a highlight's shadow).
custom-highlight-painting-text-shadow.html and
custom-highlight-painting-text-shadow-invalidation.html now pass
* LayoutTests/TestExpectations:
* Source/WebCore/rendering/StyledMarkedText.cpp:
(WebCore::computeStyleForPseudoElementStyle):
(WebCore::coalesceAdjacentWithSameRanges):
Canonical link: https://commits.webkit.org/317374@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
