Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 65eacbe9735daecfe614c69284e50b1fcf384e95
https://github.com/WebKit/WebKit/commit/65eacbe9735daecfe614c69284e50b1fcf384e95
Author: Alan Baradlay <[email protected]>
Date: 2026-07-17 (Fri, 17 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexLayout.cpp
M Source/WebCore/rendering/RenderFlexLayout.h
Log Message:
-----------
[cleanup] Move computeFlexItemRects out of performFlexLayout into a dedicated
FlexLayout member function
https://bugs.webkit.org/show_bug.cgi?id=318630
Reviewed by Antti Koivsito.
The final placement step of the flex pipeline -- position each item at its
final flow-aware location,
applying the wrap-reverse and rtl-column cross-axis flips, then write it to the
renderer -- was a
lambda captured inside performFlexLayout, unlike the other pipeline steps which
are FlexLayout member
functions.
Lift it into a computeFlexItemRects member function alongside the others,
turning the seven captured
locals into parameters (the flex lines and items, the item positions, the two
per-line cross lists,
the per-item cross sizes, and the cross-axis start edge, which is snapshotted
before align-content
shifts the positions). The name matches the counterpart in the LFC
Layout::FlexLayout the legacy path
is converging on.
No change in behavior: the body is unchanged, only relocated and parameterized.
* Source/WebCore/rendering/RenderFlexLayout.cpp:
* Source/WebCore/rendering/RenderFlexLayout.h:
Canonical link: https://commits.webkit.org/317407@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
