Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a802589bbc38ecb2dccee0a1605d620ca7ec808d
https://github.com/WebKit/WebKit/commit/a802589bbc38ecb2dccee0a1605d620ca7ec808d
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-07-17 (Fri, 17 Jul 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
Log Message:
-----------
[AppKit Gestures] Occasionally getting AppKit error logging in
-gestureRecognizerShouldBegin: ("WKDeferringGestureRecognizer is responsible
for implementing locationInView:")
https://bugs.webkit.org/show_bug.cgi?id=319661
rdar://182496998
Reviewed by Richard Robinson.
WKDeferringGR currently does _not_ override -locationInView:, mainly
because it does not make sense for the deferring GR to _have_ an
associated location.
NSGestureRecognizer emits error logging for subclasses like this, while
UIGestureRecognizer simply returns the centroid of active touches (for
that gesture).
A first instinct to just return (0, 0) may be incompatible on iOS, so
instead we should simply avoid calling into
`-[WKDeferringGestureRecognizer locationInView:]` from
AppKitGestureController. -gestureRecognizerShouldBegin: always falls
through to return YES for deferring GRs regardless, so we shortcircuit
that earlier, avoiding the `-locationInView:` call.
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController gestureRecognizerShouldBegin:]):
Canonical link: https://commits.webkit.org/317417@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
