Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6ce0d1f6a9460f363bc266428c05dfbaf6e52950
https://github.com/WebKit/WebKit/commit/6ce0d1f6a9460f363bc266428c05dfbaf6e52950
Author: Alan Baradlay <[email protected]>
Date: 2026-07-17 (Fri, 17 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexLayout.cpp
M Source/WebCore/rendering/RenderFlexLayout.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
Log Message:
-----------
[cleanup] Take FlexLayout's used cross size from
updateFlexContainerLogicalHeight instead of reading it off the container
https://bugs.webkit.org/show_bug.cgi?id=318648
Reviewed by Antti Koivisto.
FlexLayout read the flex container's used cross size live off the container
(crossAxisContentExtent
and crossAxisExtent, via FlexLayoutUtils) in five places: the single-line
height, the align-content
pass, the two stretch helpers, and the final item placement. That size is only
settled once
updateFlexContainerLogicalHeight has resolved the container's logical height
(9.6 #15), so each of
those reads reached back through the container after the fact.
Have updateFlexContainerLogicalHeight return the used cross extents instead, as
a
FlexContainerCrossExtents: the content-box extent (line positioning,
align-content, and each item's
cross size) and the border-box extent (the right-to-left column flip). layout()
captures them once
and threads them to the consumers, so FlexLayout no longer reads the
container's cross size anywhere.
No change in behavior.
* Source/WebCore/rendering/RenderFlexLayout.cpp:
* Source/WebCore/rendering/RenderFlexLayout.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
* Source/WebCore/rendering/RenderFlexibleBox.h:
Canonical link: https://commits.webkit.org/317446@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
