Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c35e39f7208608e335e85b3c121b938c6549307c
https://github.com/WebKit/WebKit/commit/c35e39f7208608e335e85b3c121b938c6549307c
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-18 (Sat, 18 Jul 2026)
Changed paths:
M Tools/Scripts/filter-test-logs
Log Message:
-----------
[WKCI] filter-test-logs can cause that buildbot ends killing an in-progress
step when the test runner produces output slowly
https://bugs.webkit.org/show_bug.cgi?id=319686
Reviewed by Nikolas Zimmermann.
When a build step runs through filter-test-logs, buildbot only sees the
few lines the filter prints, since the full output goes to a log file.
To avoid buildbot killing the step for lack of output, filter-test-logs
prints a progress line from time to time. But the check to wether it
should print the summary por not ran only once every 100 lines.
With a command that prints slowly (for example one line every 15 seconds),
the check ran once every 1500 seconds which is above the standard 1200
buildbot timeout, so buildbot killed the step with "command timed
out: XXX seconds without output".
This patch changes it to run the check if it should print the summary for
every line received. Calling time.time() is way cheaper than I thought at
303319@main
I have benchmarked this an the cost is well under 100 nanoseconds per call,
so doing it once per line adds only a few milliseconds to a standard layout
test run with ~150k lines.
The format to print the summary is also improved, now includes a timestamp
and how many lines arrived since the last update.
The frequency to print the summary is changed to once per minute instead of
once each 5 minutes, that should not be an issue for buildbot to handle, and
makes more interactive and helpful to look at the progress of a filtered
on-going build.
* Tools/Scripts/filter-test-logs:
(KeepAliveStdoutProgress):
(KeepAliveStdoutProgress.__init__):
(KeepAliveStdoutProgress.maybe_update_progress):
Canonical link: https://commits.webkit.org/317461@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
