Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5750973a2f6600e8f79d9b8d12a9d5e2269e916
https://github.com/WebKit/WebKit/commit/b5750973a2f6600e8f79d9b8d12a9d5e2269e916
Author: Alan Baradlay <[email protected]>
Date: 2026-07-18 (Sat, 18 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode.html
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
An empty editable flex container does not reserve a line's worth of block
size in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=318673
<rdar://problem/181485387>
Reviewed by Antti Koivisto.
<div contenteditable style="display: flex; writing-mode: vertical-rl;
height: 100px"></div>
The empty flex container should be one line tall along its block axis, so 20px
wide here. Instead it
collapsed to zero width.
An editable flex container has a line even when empty, so it reserves at least
one line's worth of size
along its block axis. That minimum was applied by comparing it against
borderBoxHeight(), the container's
physical height, which is the inline extent in a vertical writing mode rather
than the block axis, so the
floor never took effect.
Fold the empty-line minimum into the block-axis max in
updateFlexContainerLogicalHeight so it floors the
logical height directly, independent of writing mode.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(RenderFlexibleBox::updateFlexContainerLogicalHeight):
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-container-line-if-empty-vertical-writing-mode-expected.html:
Added.
Canonical link: https://commits.webkit.org/317467@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
