Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1cae83e7ff24c43499c7436650e4395578e562d
https://github.com/WebKit/WebKit/commit/b1cae83e7ff24c43499c7436650e4395578e562d
Author: Alan Baradlay <[email protected]>
Date: 2026-07-18 (Sat, 18 Jul 2026)
Changed paths:
M Source/WebCore/rendering/RenderFlexLayout.cpp
Log Message:
-----------
[cleanup] Resolve a flex item's aspect-ratio percentage cross size against
the container's logical inline size
https://bugs.webkit.org/show_bug.cgi?id=318691
Reviewed by Antti Koivisto.
computeMainSizeFromAspectRatioUsing resolved a column flex item's
percentage/calc cross size against the
container's physical contentBoxWidth(), even though layout should operate on
logical geometry. Use
contentBoxLogicalWidth() instead: the cross axis in column flow is the
container's inline axis, so its
inline content size is the correct basis. This also removes the last
physical-geometry read from FlexLayout.
Behavior-neutral in horizontal writing mode, where the logical inline size and
the physical width are the
same value; in a vertical writing mode it aligns the resolution to the logical
inline size rather than the
physical width (the block/main extent).
* Source/WebCore/rendering/RenderFlexLayout.cpp:
(WebCore::FlexLayout::computeMainSizeFromAspectRatioUsing):
Canonical link: https://commits.webkit.org/317492@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications