Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c3785b72e0af3cf6bd8db6d5c0b180484dca9011
https://github.com/WebKit/WebKit/commit/c3785b72e0af3cf6bd8db6d5c0b180484dca9011
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-07-19 (Sun, 19 Jul 2026)
Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
Synthetic click based DOM dblclick support should be available for all
ENABLE_TWO_PHASE_CLICKS configurations
https://bugs.webkit.org/show_bug.cgi?id=319777
rdar://182636942
Reviewed by Richard Robinson.
This patch migrates WebPage::handleDoubleTapForDoubleClickAtPoint(),
along with associated IPC support, out of iOS-only code paths into the
shared ENABLE(TWO_PHASE_CLICKS) path, so any configuration that enables
two-phase clicks can dispatch a DOM dblclick and a detail==2 click.
To achieve this, on top of just search-and-replacing platform guards,
we plumb the mouse event input source and synthetic click type through
the double click IPC message instead of hardcoding them. The iOS caller
explicitly passes the previous defaults UserDefault and OneFingerTap.
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _doubleTapRecognizedForDoubleClick:]):
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::handleDoubleTapForDoubleClickAtPoint): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::windowWithDoubleClickEventListener):
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::windowWithDoubleClickEventListener): Deleted.
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint): Deleted.
Canonical link: https://commits.webkit.org/317523@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
