Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b6bc22d817db341643b972c6e18e4d81059abcc
https://github.com/WebKit/WebKit/commit/3b6bc22d817db341643b972c6e18e4d81059abcc
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-07-20 (Mon, 20 Jul 2026)
Changed paths:
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.h
M Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
Log Message:
-----------
[CMake] macOS build broke after 317523@main (redefinition of
'windowWithDoubleClickEventListener')
https://bugs.webkit.org/show_bug.cgi?id=319822
rdar://182720554
Reviewed by Taher Ali and Zak Ridouh.
After windowWithDoubleClickEventListener() moved from WebPageIOS to
WebPageCocoa, the CMake builds started failing because there were two
identical definitions in WebPageCocoa and PositionInformationForWebPage,
respectively. This produced a collision when both of these files ended
up in the same unified source bundle.
This patch addresses the error by consolidating as a LocalFrame method
instead.
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::windowWithDoubleClickEventListener const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/PositionInformationForWebPage.mm:
(WebKit::positionInformationForWebPage):
(WebKit::windowWithDoubleClickEventListener): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::handleDoubleTapForDoubleClickAtPoint):
(WebKit::windowWithDoubleClickEventListener): Deleted.
Canonical link: https://commits.webkit.org/317555@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
