Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8e0a1f8b1e39496c4678521c1edf0410b90ab455
https://github.com/WebKit/WebKit/commit/8e0a1f8b1e39496c4678521c1edf0410b90ab455
Author: Basuke Suzuki <[email protected]>
Date: 2026-07-20 (Mon, 20 Jul 2026)
Changed paths:
M Source/WebCore/Modules/webtransport/WebTransportSendStream.h
M Source/WebCore/Modules/webtransport/WebTransportSendStream.idl
M Source/WebCore/Modules/webtransport/WebTransportSendStreamOptions.h
M Source/WebCore/Modules/webtransport/WebTransportSendStreamOptions.idl
Log Message:
-----------
[WebTransport] Make WebTransportSendStream.sendOrder and
WebTransportSendStreamOptions non-nullable to match spec
https://bugs.webkit.org/show_bug.cgi?id=310559
rdar://182738080
Reviewed by Alex Christensen.
Per the WebTransport spec change (w3c/webtransport commit 37d1d28), sendOrder is
non-nullable (defaulting to 0) and WebTransportSendStreamOptions inherits from
WebTransportSendOptions. WebTransportSendOptions and
WebTransportDatagramsWritable already
used the non-nullable form; this brings the remaining two declarations into
line:
- WebTransportSendStream.sendOrder becomes `long long` instead of `long long?`,
so assigning
null coerces to 0 per the WebIDL rules rather than being retained as null.
- WebTransportSendStreamOptions now inherits WebTransportSendOptions instead of
declaring its
own nullable sendOrder, which also gives it the inherited sendGroup member.
This covers the IDL/attribute nullability conformance only. Actual sendOrder
backend plumbing
is tracked separately in rdar://161685860, so the sendorder.https.any.* WPT
tests remain
skipped.
No new tests (IDL conformance; existing sendorder WPT tests remain skipped
pending backend
support).
* Source/WebCore/Modules/webtransport/WebTransportSendStream.h:
(WebCore::WebTransportSendStream::sendOrder):
(WebCore::WebTransportSendStream::setSendOrder):
* Source/WebCore/Modules/webtransport/WebTransportSendStream.idl:
* Source/WebCore/Modules/webtransport/WebTransportSendStreamOptions.h:
* Source/WebCore/Modules/webtransport/WebTransportSendStreamOptions.idl:
Canonical link: https://commits.webkit.org/317583@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
