Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8af1803f244592309456e88b61fe8cc2fa7cd3d9
https://github.com/WebKit/WebKit/commit/8af1803f244592309456e88b61fe8cc2fa7cd3d9
Author: Zak Ridouh <[email protected]>
Date: 2026-07-21 (Tue, 21 Jul 2026)
Changed paths:
M Source/WebKit/PlatformIOS.cmake
M Source/WebKit/WebProcess/WebPage/ios/FindIndicatorIOS.cpp
M Source/WebKitLegacy/PlatformIOS.cmake
M Tools/WebKitTestRunner/CMakeLists.txt
M Tools/WebKitTestRunner/PlatformIOS.cmake
Log Message:
-----------
[CMake] Fix the iOS simulator release build
https://bugs.webkit.org/show_bug.cgi?id=319760
rdar://182614984
Reviewed by David Kilzer.
Three independent failures caused failures for the iOS simulator CMake build:
- FindIndicatorIOS.cpp called LocalFrame::editor()/selection() without
including LocalFrameInlines.h, leaving the inline accessors undefined at
link time. Include it, as other WebKit consumers do.
- The hand-rolled WebKitSwift and _WebKit_SwiftUI Swift targets did not pass
-disable-sandbox, so @Entry macro expansion failed when the build ran inside
a sandbox (swift-plugin-server cannot nest sandbox-exec). Mirror the flag the
shared Swift macro already sets for WebKit / WebGPU / PAL.
- WebKitLegacy's iOS forwarding-header step symlinked Headers/WebKit ->
Headers/WebKitLegacy so <WebKit/...> imports resolved to the legacy umbrella.
That WebKit1 <WebKit/WebKit.h> (no WKWebView) shadowed modern WebKit2's on
the CMake include path, collapsing WebKitTestRunner's
TestRunnerWKWebView to a root
class. The shipped SDK's <WebKit/WebKit.h> is WebKit2 and the migrated legacy
headers are reachable as <WebKitLegacy/...>, so drop the symlink. Also stop
pulling WebKitLegacy into WebKitTestRunner on iOS, which uses
WebKit2 only.
* Source/WebKit/PlatformIOS.cmake:
* Source/WebKit/WebProcess/WebPage/ios/FindIndicatorIOS.cpp:
* Tools/WebKitTestRunner/CMakeLists.txt:
* Tools/WebKitTestRunner/PlatformIOS.cmake:
* Source/WebKitLegacy/PlatformIOS.cmake:
Canonical link: https://commits.webkit.org/317605@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
