Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f72201f17442df3a97c0b5edc91b14e6157a51b3
https://github.com/WebKit/WebKit/commit/f72201f17442df3a97c0b5edc91b14e6157a51b3
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-25 (Sat, 25 Jul 2026)
Changed paths:
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py
Log Message:
-----------
lint-test-expectations never applies glib-specific TestExpectations override
for GTK/WPE ports
https://bugs.webkit.org/show_bug.cgi?id=320272
rdar://183191094
Reviewed by Patrick Griffis.
lint_test_expectations.py compared the Port object itself against the
strings 'gtk' and 'wpe' instead of comparing port_to_lint.port_name.
Port has no __eq__, so the comparison was always False and the
glib-specific TestExpectations override (LayoutTests/platform/glib/
TestExpectations) was silently never added for either port.
* Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py:
(lint): Compare port_to_lint.port_name instead of port_to_lint.
* Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
(FakePort.__init__): Add port_name and _options so tests can exercise
the glib-expectations branch.
(LintTest.test_glib_additional_expectations): Added. Verifies gtk and
wpe ports get the glib TestExpectations override and other ports don't.
Canonical link: https://commits.webkit.org/317925@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
