Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: faf76febcd287b3d3a959104f60587ba7a9ce80b
https://github.com/WebKit/WebKit/commit/faf76febcd287b3d3a959104f60587ba7a9ce80b
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-26 (Sun, 26 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
Log Message:
-----------
[WKCI][ews-build.webkit.org][WPE] The WPE-JSC queue should use build-webkit
instead build-jsc to build without change.
https://bugs.webkit.org/show_bug.cgi?id=320284
Reviewed by Nikolas Zimmermann.
The new WPE-JSC queue added in 317773@main is not working well because
when there are failures it tries to use script build-jsc instead of
build-webkit to rebuild WPE without change.
And it fails because script build-jsc does not currently implement the
auto enter mechanism into the SDK.
Fixing build-jsc is in theory possible, but this changes the EWS logic
to use script build-webkit for GTK and WPE ports in this case because:
- The build product it receives it was generated with build-webkit
(not with build-jsc)
- build-jsc has different quirks than build-webkit and doesn't enable
the same CMake switches by default.
- Thanks to the shared ccache building webkit is very fast if the caches
are hot and for a "build without change" step the caches should be hot,
so I don' think is worth optimizing the time this step takes.
- The post-commit bots that run JSC test with WPE also use build-webkit
script to build.
- In the case of WPE there isn't a split of libjsc and libwebkit, so to
link the jsc binary is needed to build all of libwebkit in any case.
So I think is better to standarize on build-webkit rather than trying
to maintain build-jsc to have the same quirks/default_flags than
build-webkit.
* Tools/CISupport/ews-build/steps.py:
(shouldBuildJSCOnly):
(CompileWebKit.evaluateCommand):
(AnalyzeCompileWebKitResults.run):
(AnalyzeCompileWebKitResults.analyzeResults):
(RunJavaScriptCoreTests.evaluateCommand):
Canonical link: https://commits.webkit.org/317938@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
