Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 67c65bcbe9f7bb5139b087c237b2864c2d08abb9
https://github.com/WebKit/WebKit/commit/67c65bcbe9f7bb5139b087c237b2864c2d08abb9
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-07-27 (Mon, 27 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/results_db.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[WKCI][ews-build.webkit.org] Results database queries fail for the GTK and
WPE ports because of using lowercase platform name.
https://bugs.webkit.org/show_bug.cgi?id=320402
Reviewed by Nikolas Zimmermann.
The EWS was failing to query the results database for the GTK and WPE ports due
to a
mismatch on the port name. The post-commit bots uploading the results where
using all
upper-case for the platform name but the EWS bots were trying to query those
results
using lowercase (because lowercase is the default on EWS config.json file) and
that
code runs on the EWS server, but on the post-commit bots the port name is
decided
by the webkit tooling that runs on the worker rather than by the buildbot
server.
More specifically on the worker (post-commit) when uploading the info the
uppercase
name is set by computeFullConfiguration() in run-javascriptcore-tests, and in
webkitpy at port.configuration_for_upload() for api and layout tests.
So this was causing that all the queries from the EWS to the results DB were
failing with error (HTTP 400) for GTK and WPE.
Fix this by adding a function platform_for_query() that ensures to return the
upper case name for GTK and WPE when doing the queries to results.webkit.org
* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase):
(ResultsDatabase.platform_for_query):
* Tools/CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.filter_failures_using_results_db):
(RunWebKitTests.filter_failures_using_results_db):
(RunAPITests.filter_api_test_failures_using_results_db):
(FindUnexpectedStaticAnalyzerResults.filter_results_using_results_db):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFilterLayoutTestFailuresUsingResultsDB):
(TestFilterLayoutTestFailuresUsingResultsDB.test_wpe_platform_is_translated_to_uppercase_for_results_db):
(TestFilterLayoutTestFailuresUsingResultsDB.test_wpe_platform_is_translated_to_uppercase_for_results_db.fake_is_pre_existing):
Canonical link: https://commits.webkit.org/318013@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
