Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2429bc7943a842d3b066cbb4a63bd8930d9388a
https://github.com/WebKit/WebKit/commit/f2429bc7943a842d3b066cbb4a63bd8930d9388a
Author: Ian Grunert <[email protected]>
Date: 2026-07-27 (Mon, 27 Jul 2026)
Changed paths:
M Source/JavaScriptCore/heap/Heap.h
M Source/ThirdParty/skia/CMakeLists.txt
M Source/WTF/wtf/SegmentedVector.h
M Source/WTF/wtf/win/DbgHelperWin.cpp
M Source/WTF/wtf/win/ThreadingWin.cpp
M Source/WebCore/platform/network/curl/OpenSSLHelper.cpp
M Source/cmake/OptionsWin.cmake
M Tools/TestRunnerShared/TestFeatures.cpp
Log Message:
-----------
[Win] Build fixes August 27
https://bugs.webkit.org/show_bug.cgi?id=320179
Unreviewed build fix.
Fix several independent breakages of the Windows build, found by
building main in the Windows EWS configuration now that its image
includes Swift 6.3.3:
*
Source/cmake/OptionsWin.cmake:
Opt out of the Swift prototype features like OptionsIOS.cmake does.
They default on for any Clang host with swiftc >= 6.3, which now
includes the Windows bots, and enabling them makes CMAKE_Swift_COMPILER
the swiftc-wrapper.sh bash script, which Windows cannot execute.
* Source/WTF/wtf/SegmentedVector.h:
(WTF::SegmentedVector::allocateSegment):
static_assert(!sizeof(Segment)) from 317919@main only holds for the
Itanium ABI; MSVC sizes the empty Segment as alignof(T). Keep sizeof()
on non-Windows and check offsetof(Segment, m_entries) on Windows.
* Source/JavaScriptCore/heap/Heap.h:
Add JS_EXPORT_PRIVATE to the friend declarations so GCOwnedDataScope.h
does not add dllimport on a redeclaration, an error under
-Wdll-attribute-on-redeclaration.
* Source/ThirdParty/skia/CMakeLists.txt:
Add src/core/SkStrikeRef.cpp, new in the 2026-06-18 Skia update but
missing from the source list, leaving its constructor undefined.
*
Source/WebCore/platform/network/curl/OpenSSLHelper.cpp:
(OpenSSL::toString):
Restore toString(), removed by 315672@main as unused; Windows needs it
for getSubjectEntry() and getSubjectAltName(). OS(WINDOWS)-guarded
because the PlayStation port builds without it and fails
-Wunused-function with it present.
* Source/WTF/wtf/win/DbgHelperWin.cpp:
* Source/WTF/wtf/win/ThreadingWin.cpp:
* Tools/TestRunnerShared/TestFeatures.cpp:
Fix -Wformat errors, fatal since LOG_ERROR gained WTF_ATTRIBUTE_PRINTF:
GetLastError() is a DWORD, errno is an int, and
std::filesystem::path::c_str() is wchar_t* on Windows.
Canonical link:
https://flagged.apple.com:443/proxy?t2=dm3x3f4pT0&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE4MDMwQG1haW4=&emid=4805b653-5780-4b8f-8bf4-880eeeaa7ee4&c=11
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
