Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9e71a47bda4c0b2d1fbe26d8f77dfb318e9d923b
      
https://github.com/WebKit/WebKit/commit/9e71a47bda4c0b2d1fbe26d8f77dfb318e9d923b
  Author: Zak Ridouh <[email protected]>
  Date:   2026-07-29 (Wed, 29 Jul 2026)

  Changed paths:
    M Source/cmake/SymlinkHeaders.cmake

  Log Message:
  -----------
  [CMake] [iOS] Stop spawning readlink for every staged framework header
https://bugs.webkit.org/show_bug.cgi?id=320293
rdar://183226312

Reviewed by Pascoe.

SymlinkHeaders.cmake spawned readlink through execute_process for every entry
to check whether an existing symlink already pointed at the right file. The
target that runs it, WebKit_StageFrameworkHeaders, is an add_custom_target with
no output, so ninja re-runs it on every build, over roughly 760 and 68 entries.

Use file(READ_SYMLINK), which needs no subprocess: re-running the script over a
directory of 503 already-staged headers drops from 1.72s to 0.02s.

* Source/cmake/SymlinkHeaders.cmake:

Canonical link: https://commits.webkit.org/318190@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to