Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c3c4867e491626b96a310a141826deb83854fc7
https://github.com/WebKit/WebKit/commit/8c3c4867e491626b96a310a141826deb83854fc7
Author: Sammy Gill <[email protected]>
Date: 2026-07-29 (Wed, 29 Jul 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp
M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h
Log Message:
-----------
[GFC] Make sure there is at least one row when ImplicitGrid is created.
https://bugs.webkit.org/show_bug.cgi?id=320581
rdar://problem/183558439
Reviewed by Alan Baradlay.
When an ImplicitGrid is created we first compute the dimensions of the
grid by looping over the placement of the grid items. This is then
passed into the constructor and the grid keeps track of the initial
number of implicit columns as a member.
This member is only used in one place: the public API on ImplicitGrid to
determine how many rows the grid has. This structure ended up resulting
in a crash when attempting to enable more content to run GFC due to
callers using rowsCount() and columnsCount(). Instead, what we can do is
just make sure there is at least one row when we calculate the implicit
grid dimensions.
Canonical link: https://commits.webkit.org/318221@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
