Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2988007e86ec3f0646c78b960e4eff8a38a24e7
https://github.com/WebKit/WebKit/commit/f2988007e86ec3f0646c78b960e4eff8a38a24e7
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M Source/WebCore/cssjit/SelectorCompiler.cpp
Log Message:
-----------
CSS JIT serializes the full selector text on every compile even when
disassembly dumping is disabled
https://bugs.webkit.org/show_bug.cgi?id=320624
rdar://183590585
Reviewed by Chris Dumez.
dataLogFIf() is a function, not a macro, so its arguments are evaluated
unconditionally. Every SelectorCodeGenerator construction therefore paid a
full recursive CSSSelector::selectorText() serialization plus a CString
malloc for the UTF-8 conversion, then discarded both, since
dumpCSSJITDisassembly is off in every shipping configuration.
Gate the work behind if (shouldDumpCSSJITDisassembly()) and call dataLogF()
directly, matching how the rest of this file guards disassembly-only work.
No behavior change, so no new tests.
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Canonical link: https://commits.webkit.org/318245@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
