Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ccea3d8723c964e5d3cef2ff2afacaf841bf93fb
https://github.com/WebKit/WebKit/commit/ccea3d8723c964e5d3cef2ff2afacaf841bf93fb
Author: Ryan Haddad <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Parent build retries in AnalyzeLayoutTestsResults should only trigger
the builder that made the request
https://bugs.webkit.org/show_bug.cgi?id=320576
Reviewed by Aakash Jain.
AnalyzeLayoutTestsResults.retry_build() already passes triggers=[scheduler]
when re-triggering
its parent archive build, intending for that rebuild to only re-run the tester
that asked for
the retry. That value never reached the new parent build, so every automatic
retry fanned out
to the parent's full set of configured testers.
To fix this, pass the explicit list instead. ConfigureBuild already declines to
overwrite a pre-set 'triggers'
property, which is the same mechanism the force-retry-<builder> schedulers rely
on, so no other
changes are needed.
* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers): Pass the explicit trigger list rather
than a renderable
that reads the wrong build's property.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResults.test_retry_build_triggers_only_current_queue):
Add unit test.
(TestTrigger.test_triggers_property_passes_explicit_list): Ditto.
(TestTrigger.test_triggers_property_is_not_a_renderable): Ditto.
Canonical link: https://commits.webkit.org/318261@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
