Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9636543604b585aaebbfc937370f05d0eace4574
https://github.com/WebKit/WebKit/commit/9636543604b585aaebbfc937370f05d0eace4574
Author: Chris Dumez <[email protected]>
Date: 2026-07-30 (Thu, 30 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation.html
M Source/WebCore/svg/SVGFEDropShadowElement.cpp
Log Message:
-----------
feDropShadow ignores stdDeviation Y update when X changes
https://bugs.webkit.org/show_bug.cgi?id=320636
Reviewed by Darin Adler.
SVGFEDropShadowElement::setFilterEffectAttribute() updated the drop-shadow's
standard deviation with:
```
return effect.setStdDeviationX(stdDeviationX()) ||
effect.setStdDeviationY(stdDeviationY());
```
FEDropShadow::setStdDeviationX() returns true when the x deviation actually
changes, so the || short-circuits and setStdDeviationY() is never called. When
the stdDeviation attribute of an already-built feDropShadow is changed (via
setAttribute or SMIL) such that its x component changes, the y component of the
effect is left stale and the shadow is repainted with the wrong vertical blur.
Evaluate both setters into separate booleans before combining them, matching
the pattern already used by SVGFEGaussianBlurElement.
Test:
imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation.html
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/svg-mutation-fedropshadow-stddeviation.html:
Added.
* Source/WebCore/svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::setFilterEffectAttribute):
Canonical link: https://commits.webkit.org/318281@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
