Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ac65c75c519148bb01f9b4004a3016df5d6fe8a7
https://github.com/WebKit/WebKit/commit/ac65c75c519148bb01f9b4004a3016df5d6fe8a7
Author: Kiet Ho <[email protected]>
Date: 2026-08-01 (Sat, 01 Aug 2026)
Changed paths:
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/style/AnchorPositionEvaluator.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilderState.h
M Source/WebCore/style/StyleSubstitutionResolver.cpp
M Source/WebCore/style/values/non-standard/StyleWebKitTextStrokeWidth.cpp
Log Message:
-----------
Remove duplicate methods in Style::BuilderState
rdar://183453037
https://bugs.webkit.org/show_bug.cgi?id=320485
Reviewed by Sam Weinig.
Style::BuilderState has different getters that return the same thing:
* style() and renderStyle()
* parentStyle() and parentRenderStyle()
* rootElementStyle() and rootElementRenderStyle()
This patch cleans things up by removing renderStyle(), parentRenderStyle()
and rootElementRenderStyle().
Refactoring, tested by existing test suite.
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::CSSToLengthConversionData):
* Source/WebCore/style/AnchorPositionEvaluator.cpp:
(WebCore::Style::AnchorPositionEvaluator::findAnchorForAnchorFunctionAndAttemptResolution):
(WebCore::Style::AnchorPositionEvaluator::evaluate):
(WebCore::Style::AnchorPositionEvaluator::evaluateSize):
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::adjustAfterApplying):
* Source/WebCore/style/StyleBuilderState.h:
(WebCore::Style::BuilderState::style): Deleted.
(WebCore::Style::BuilderState::style const): Deleted.
(WebCore::Style::BuilderState::parentStyle const): Deleted.
(WebCore::Style::BuilderState::rootElementStyle const): Deleted.
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::resolveAndRegisterDashedFunctionArguments):
(WebCore::Style::SubstitutionResolver::substituteDashedFunction):
* Source/WebCore/style/values/non-standard/StyleWebKitTextStrokeWidth.cpp:
(WebCore::Style::CSSValueConversion<WebkitTextStrokeWidth>::operator):
Canonical link: https://commits.webkit.org/318373@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
