Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 82c30dd925e1726383e951ede5e761a56c991665
https://github.com/WebKit/WebKit/commit/82c30dd925e1726383e951ede5e761a56c991665
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Source/WebCore/xml/XMLHttpRequestUpload.cpp
Log Message:
-----------
Remove unreachable null check in
XMLHttpRequestUpload::scriptExecutionContext()
https://bugs.webkit.org/show_bug.cgi?id=320891
rdar://183909422
Reviewed by Chris Dumez.
WeakRef::ptr() ends in RELEASE_ASSERT(ptr), so it never returns null and the
early return was dead code. Use protect() to get the counted reference in a
single expression, matching eventListenersDidChange() just above; dereferencing
the WeakRef directly would pass an uncounted 'this' and trip Safer C++.
No change in behavior.
* Source/WebCore/xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::scriptExecutionContext const):
Canonical link: https://commits.webkit.org/318532@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
