Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: badd29074be777b8d710099a0d478211333a227c
https://github.com/WebKit/WebKit/commit/badd29074be777b8d710099a0d478211333a227c
Author: Sam Weinig <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-computed-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-computed.html
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/computed/StyleComputedStyleBase.cpp
M Source/WebCore/style/computed/StyleComputedStyleBase.h
M Source/WebCore/style/values/primitives/StyleLengthResolution.cpp
Log Message:
-----------
[EvaluationTimeZoom] Line-height units don't work correctly with zoom
https://bugs.webkit.org/show_bug.cgi?id=320921
Reviewed by Antti Koivisto.
Refactor `lh` and `rlh` unit resolution to share the same implementation
(like the other font-relative units) and to use unzoomed / specified values.
The refactor revealed that we were only setting one of the two line-height
computed style data members during animations, so this was fixed as well.
Test:
imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-computed.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-computed-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-computed.html:
Added.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/computed/StyleComputedStyleBase.cpp:
* Source/WebCore/style/computed/StyleComputedStyleBase.h:
* Source/WebCore/style/values/primitives/StyleLengthResolution.cpp:
Canonical link: https://commits.webkit.org/318558@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
