Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: eef67ca710370cc2ed81513f5e1948ce5d47dbaf
https://github.com/WebKit/WebKit/commit/eef67ca710370cc2ed81513f5e1948ce5d47dbaf
Author: Richard Robinson <[email protected]>
Date: 2026-08-04 (Tue, 04 Aug 2026)
Changed paths:
M Source/WebGPU/WebGPU/CommandEncoder.swift
M Source/WebKit/Platform/cocoa/WKMaterialHostingSupport.swift
M Source/WebKit/Platform/spi/visionos/WKSurroundingsEffect.swift
M Source/WebKit/Platform/spi/visionos/WKSurroundingsEffectView.swift
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration+Extras.swift
M Source/WebKit/UIProcess/API/Cocoa/WebKitSwiftOverlay.swift
M Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.swift
M Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift
M Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift
M Source/WebKit/UIProcess/API/Swift/WebPage+SPI.swift
M Source/WebKit/UIProcess/API/Swift/WebPage+Transferable.swift
M Source/WebKit/UIProcess/API/Swift/WebPage.swift
M
Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift
M Source/WebKit/UIProcess/Cocoa/WKScrollGeometryAdapter.swift
M Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift
M Source/WebKit/UIProcess/Cocoa/WebPageWebView.swift
M Source/WebKit/UIProcess/WebBackForwardList.swift
M
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentController.swift
M
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentRawRequestValidator.swift
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift
M Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaTypes.swift
M Source/WebKit/WebKitSwift/TextAnimation/WKTextAnimationManagerIOS.swift
M
Source/WebKit/WebKitSwift/WritingTools/IntelligenceTextEffectViewManager.swift
M
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift
M
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift
M
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift
M Source/WebKit/_WebKit_SwiftUI/API/View+WebViewModifiers.swift
M Source/WebKit/_WebKit_SwiftUI/API/WebPage+SwiftUI.swift
M Source/WebKit/_WebKit_SwiftUI/API/WebView.swift
M Source/WebKit/_WebKit_SwiftUI/API/WebViewImmersiveEnvironmentView.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/PlatformTextSearching.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/SwiftUI+Extras.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifierContexts.swift
M Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift
M Tools/Scripts/webkitpy/style/checker.py
M Tools/Scripts/webkitpy/style/checker_unittest.py
M Tools/Scripts/webkitpy/style/checkers/swift.py
M Tools/Scripts/webkitpy/style/checkers/swift_unittest.py
M Tools/TestWebKitAPI/Helpers/cocoa/AppKit+Extras.swift
M Tools/TestWebKitAPI/Helpers/cocoa/SwiftUI+Extras.swift
M Tools/TestWebKitAPI/Helpers/cocoa/TestPDFDocument.swift
M Tools/TestWebKitAPI/Helpers/cocoa/WebPage+Extras.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/EditingFontSizeTests.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageMouseEventsTests.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageTransferableTests.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebViewTests.swift
Log Message:
-----------
[Swift in WebKit] Replace Swift platform compilation conditions with WTF ones
https://bugs.webkit.org/show_bug.cgi?id=320963
rdar://183988778
Reviewed by Mike Wyrzykowski and Megan Gardner.
We currently use a mix of Swift `os(...)` checks and WTF platform checks in
Swift.
Replace all of the former with the latter for consistency, and add a style
checker
rule to enforce this.
Tests: Tools/TestWebKitAPI/Tests/WebKit/WebPage/EditingFontSizeTests.swift
Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageMouseEventsTests.swift
Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageTransferableTests.swift
Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebViewTests.swift
* Source/WebGPU/WebGPU/CommandEncoder.swift:
(WebGPU.finish(_:)):
* Source/WebKit/Platform/cocoa/WKMaterialHostingSupport.swift:
(MaterialHostingView.body):
* Source/WebKit/Platform/spi/visionos/WKSurroundingsEffect.swift:
* Source/WebKit/Platform/spi/visionos/WKSurroundingsEffectView.swift:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration+Extras.swift:
* Source/WebKit/UIProcess/API/Cocoa/WebKitSwiftOverlay.swift:
* Source/WebKit/UIProcess/API/Cocoa/_WKTextExtraction.swift:
* Source/WebKit/UIProcess/API/Swift/WebPage+Configuration.swift:
* Source/WebKit/UIProcess/API/Swift/WebPage+NavigationDeciding.swift:
* Source/WebKit/UIProcess/API/Swift/WebPage+SPI.swift:
* Source/WebKit/UIProcess/API/Swift/WebPage+Transferable.swift:
* Source/WebKit/UIProcess/API/Swift/WebPage.swift:
(backingWebView):
* Source/WebKit/UIProcess/Cocoa/TextExtraction/WKWebView+TextExtraction.swift:
* Source/WebKit/UIProcess/Cocoa/WKScrollGeometryAdapter.swift:
* Source/WebKit/UIProcess/Cocoa/WKUIDelegateAdapter.swift:
* Source/WebKit/UIProcess/Cocoa/WebPageWebView.swift:
* Source/WebKit/UIProcess/WebBackForwardList.swift:
(MakeAPIArray.didRemoveItem(_:)):
(MakeAPIArray.messageCheckItemURLs(_:process:)):
*
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentPresentmentController.swift:
*
Source/WebKit/WebKitSwift/IdentityDocumentServices/WKIdentityDocumentRawRequestValidator.swift:
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaPlayer.swift:
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaTypes.swift:
* Source/WebKit/WebKitSwift/TextAnimation/WKTextAnimationManagerIOS.swift:
*
Source/WebKit/WebKitSwift/WritingTools/IntelligenceTextEffectViewManager.swift:
(setupViewIfNeeded):
*
Source/WebKit/WebKitSwift/WritingTools/PlatformIntelligenceTextEffectView.swift:
(PlatformIntelligenceTextEffectView.removeEffect(_:)):
(Previews.heightDelta):
*
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceReplacementTextEffectCoordinator.swift:
*
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceSmartReplyTextEffectCoordinator.swift:
* Source/WebKit/_WebKit_SwiftUI/API/View+WebViewModifiers.swift:
* Source/WebKit/_WebKit_SwiftUI/API/WebPage+SwiftUI.swift:
(WebPage.themeColor):
* Source/WebKit/_WebKit_SwiftUI/API/WebView.swift:
(WebView.representable):
* Source/WebKit/_WebKit_SwiftUI/API/WebViewImmersiveEnvironmentView.swift:
(WebViewImmersiveEnvironmentView.body):
* Source/WebKit/_WebKit_SwiftUI/Implementation/CocoaWebViewAdapter.swift:
(CocoaWebViewAdapter.isFindNavigatorVisible):
(CocoaWebViewAdapter.findInteraction):
(CocoaWebViewAdapter.webView):
* Source/WebKit/_WebKit_SwiftUI/Implementation/PlatformTextSearching.swift:
* Source/WebKit/_WebKit_SwiftUI/Implementation/SwiftUI+Extras.swift:
* Source/WebKit/_WebKit_SwiftUI/Implementation/ViewModifierContexts.swift:
* Source/WebKit/_WebKit_SwiftUI/Implementation/WebViewRepresentable.swift:
(WebViewRepresentable.makePlatformView(_:)):
(WebViewRepresentable.updatePlatformView(_:context:)):
(WebViewRepresentable.dismantlePlatformView(_:coordinator:)):
(WebViewCoordinator.updateFindInteraction(_:context:)):
(WebViewRepresentable.setupRefreshControl(_:)):
* Tools/Scripts/webkitpy/style/checker.py:
(_all_categories):
* Tools/Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):
* Tools/Scripts/webkitpy/style/checkers/swift.py:
(SwiftChecker):
(SwiftChecker._check_platform_conditions):
(SwiftChecker.check):
* Tools/Scripts/webkitpy/style/checkers/swift_unittest.py:
(SwiftCheckerTest.test_check_safe):
(SwiftPlatformConditionTest):
(SwiftPlatformConditionTest._errors_for_lines):
(SwiftPlatformConditionTest._errors_for_lines._mock_handle_style_error):
(SwiftPlatformConditionTest._expected_error):
(SwiftPlatformConditionTest.test_simple_conditions):
(SwiftPlatformConditionTest.test_negated_condition):
(SwiftPlatformConditionTest.test_indented_condition):
(SwiftPlatformConditionTest.test_elseif_condition):
(SwiftPlatformConditionTest.test_compound_conditions):
(SwiftPlatformConditionTest.test_repeated_condition):
(SwiftPlatformConditionTest.test_version_gated_can_import_is_allowed):
(SwiftPlatformConditionTest.test_other_conditions_are_allowed):
(SwiftPlatformConditionTest.test_wtf_platform_conditions_are_allowed):
(SwiftPlatformConditionTest.test_non_directive_lines_are_allowed):
* Tools/TestWebKitAPI/Helpers/cocoa/AppKit+Extras.swift:
* Tools/TestWebKitAPI/Helpers/cocoa/SwiftUI+Extras.swift:
* Tools/TestWebKitAPI/Helpers/cocoa/TestPDFDocument.swift:
* Tools/TestWebKitAPI/Helpers/cocoa/WebPage+Extras.swift:
(insertText(_:)):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/EditingFontSizeTests.swift:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageMouseEventsTests.swift:
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebPageTransferableTests.swift:
(WebPageTransferableTests.exportToPDFWithoutLoadingAnyWebContentFails):
(WebPageTransferableTests.exportToImage(_:)):
(WebPageTransferableTests.exportToRichText(_:)):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/WebViewTests.swift:
Canonical link: https://commits.webkit.org/318570@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
