Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2fea5e9c6376a50df370cf88a65fa0983616282e
https://github.com/WebKit/WebKit/commit/2fea5e9c6376a50df370cf88a65fa0983616282e
Author: Ahmad Saleem <[email protected]>
Date: 2026-08-10 (Mon, 10 Aug 2026)
Changed paths:
A
LayoutTests/fast/viewport/interactive-widget-conflicting-meta-tags-expected.txt
A LayoutTests/fast/viewport/interactive-widget-conflicting-meta-tags.html
A LayoutTests/fast/viewport/interactive-widget-disabled-expected.txt
A LayoutTests/fast/viewport/interactive-widget-disabled.html
A LayoutTests/fast/viewport/interactive-widget-duplicate-key-expected.txt
A LayoutTests/fast/viewport/interactive-widget-duplicate-key.html
A LayoutTests/fast/viewport/interactive-widget-invalid-values-expected.txt
A LayoutTests/fast/viewport/interactive-widget-invalid-values.html
A
LayoutTests/fast/viewport/interactive-widget-semicolon-separator-expected.txt
A LayoutTests/fast/viewport/interactive-widget-semicolon-separator.html
A LayoutTests/fast/viewport/interactive-widget-valid-values-expected.txt
A LayoutTests/fast/viewport/interactive-widget-valid-values.html
A
LayoutTests/fast/visual-viewport/ios/interactive-widget/invalid-value-falls-back-to-resizes-visual-expected.txt
A
LayoutTests/fast/visual-viewport/ios/interactive-widget/invalid-value-falls-back-to-resizes-visual.html
Log Message:
-----------
[Test Coverage] Add tests for parsing the interactive-widget viewport meta
argument
https://bugs.webkit.org/show_bug.cgi?id=321133
rdar://184165368
Reviewed by Jessica Cheung.
We had no coverage for how the interactive-widget viewport meta argument is
parsed: the existing tests in fast/visual-viewport/ios/interactive-widget/ all
pass a valid value and exercise keyboard behavior. Nothing verified that a bad
value is rejected, or that rejecting it leaves the rest of the viewport
arguments alone.
There is no web-exposed way to read back the parsed value, so these tests
observe parsing through the warning reported by parseInteractiveWidgetValue()
and through internals.configurationForViewport(), which shows that the other
arguments still resolve as written.
Added to fast/viewport/:
- interactive-widget-invalid-values.html: an unknown value, an empty value, a
bare key with no "=", near misses ("resizes", "resizes-contentt",
"overlays_content", "RESize-CONTENT"), a value with a trailing ";", and
"RESIZES-VISUAL" spelled with U+0130 to pin that keyword matching folds ASCII
only. Each is reported and ignored, and width/initial-scale still resolve to
320x352 at scale 1.
- interactive-widget-valid-values.html: the key and its values are ASCII
case-insensitive and whitespace around "=" is allowed, so no warnings.
- interactive-widget-semicolon-separator.html: ";" is not a viewport argument
separator, so it becomes part of the preceding value while the
interactive-widget argument after it is still parsed.
- interactive-widget-duplicate-key.html: a duplicated key within one content
string is not a parse error; each occurrence is parsed in order.
- interactive-widget-conflicting-meta-tags.html: a second viewport meta tag
replaces the first tag's arguments entirely.
- interactive-widget-disabled.html: with the feature disabled the key itself is
unrecognized, even for a valid value.
Added to fast/visual-viewport/ios/interactive-widget/:
- invalid-value-falls-back-to-resizes-visual.html: an invalid value falls back
to resizes-visual rather than to some other mode, checked end to end with the
keyboard shown: the layout viewport is left unshrunk (unlike
resizes-content) while the visual viewport does shrink (unlike
overlays-content).
No change in behavior.
*
LayoutTests/fast/viewport/interactive-widget-conflicting-meta-tags-expected.txt:
Added.
* LayoutTests/fast/viewport/interactive-widget-conflicting-meta-tags.html:
Added.
* LayoutTests/fast/viewport/interactive-widget-disabled-expected.txt: Added.
* LayoutTests/fast/viewport/interactive-widget-disabled.html: Added.
* LayoutTests/fast/viewport/interactive-widget-duplicate-key-expected.txt:
Added.
* LayoutTests/fast/viewport/interactive-widget-duplicate-key.html: Added.
* LayoutTests/fast/viewport/interactive-widget-invalid-values-expected.txt:
Added.
* LayoutTests/fast/viewport/interactive-widget-invalid-values.html: Added.
*
LayoutTests/fast/viewport/interactive-widget-semicolon-separator-expected.txt:
Added.
* LayoutTests/fast/viewport/interactive-widget-semicolon-separator.html: Added.
* LayoutTests/fast/viewport/interactive-widget-valid-values-expected.txt: Added.
* LayoutTests/fast/viewport/interactive-widget-valid-values.html: Added.
*
LayoutTests/fast/visual-viewport/ios/interactive-widget/invalid-value-falls-back-to-resizes-visual-expected.txt:
Added.
*
LayoutTests/fast/visual-viewport/ios/interactive-widget/invalid-value-falls-back-to-resizes-visual.html:
Added.
Canonical link: https://commits.webkit.org/318954@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
