Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4087bd7152027907454a2b7586d21d8069c6f1d4
https://github.com/WebKit/WebKit/commit/4087bd7152027907454a2b7586d21d8069c6f1d4
Author: Marcos Caceres <[email protected]>
Date: 2026-08-16 (Sun, 16 Aug 2026)
Changed paths:
M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp
Log Message:
-----------
Suppress the NoDeleteChecker warning on IDBRequestData::isolatedCopy()
https://bugs.webkit.org/show_bug.cgi?id=321500
Reviewed by Ryosuke Niwa.
isolatedCopy() is annotated NODELETE and alpha.webkit.NoDeleteChecker objects
to it. The
constructor it calls assigns to members that have already been
default-constructed, and each
of those assignments destroys the previous empty value, so the checker sees a
possible
destruction inside the body. Nothing meaningful is destroyed, but a constructor
cannot itself
be marked NODELETE, so the annotation stays and the checker is suppressed on
the definition
instead. Callers keep the NODELETE guarantee and do not need to take a ref.
Canonical link: https://commits.webkit.org/319261@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications