Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 17e6d00a19246a5c1a9fc4d1e94f3b0ce26835ca
https://github.com/WebKit/WebKit/commit/17e6d00a19246a5c1a9fc4d1e94f3b0ce26835ca
Author: Sam Weinig <[email protected]>
Date: 2026-08-17 (Mon, 17 Aug 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/calc-computed-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/calc-computed.html
M
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/css/calc/CSSCalcValue.cpp
M Source/WebCore/css/calc/CSSCalcValue.h
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp
M Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h
M Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp
M Source/WebCore/style/calc/StyleCalculationTree+Conversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h
Log Message:
-----------
[EvaluationTimeZoom] px values in calc() expressions that survive through
computed style are being serialized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=321939
Reviewed by Sammy Gill.
Removes incorrect zoom unscaling of px values in computed value calc()
expressions
that was left over from build time zoom.
Now that no zoom unscaling is needed, the Style::ComputedStyle passed during
conversion
from Style::UnevaluatedCalculation to CSS::UnevalutatedCalc can be removed.
Also simplified
toCSS conversion for numeric types a bit by using unresolvedValue() for all
numeric types
instead of specializing for Length<>.
Test: imported/w3c/web-platform-tests/css/css-viewport/zoom/calc-computed.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/calc-computed-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/calc-computed.html:
Added.
* Source/WebCore/css/calc/CSSCalcValue.cpp:
* Source/WebCore/css/calc/CSSCalcValue.h:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.cpp:
* Source/WebCore/css/values/primitives/CSSUnevaluatedCalc.h:
* Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp:
* Source/WebCore/style/calc/StyleCalculationTree+Conversion.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+Conversions.h:
Canonical link: https://commits.webkit.org/319320@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
