Title: [115652] trunk/Source/WebCore
- Revision
- 115652
- Author
- [email protected]
- Date
- 2012-04-30 10:53:53 -0700 (Mon, 30 Apr 2012)
Log Message
Unreviewed. Fix test crashes in Win/Linux debug builds.
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8LazyEventListener.h:
(V8LazyEventListener):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115651 => 115652)
--- trunk/Source/WebCore/ChangeLog 2012-04-30 17:45:00 UTC (rev 115651)
+++ trunk/Source/WebCore/ChangeLog 2012-04-30 17:53:53 UTC (rev 115652)
@@ -1,3 +1,13 @@
+2012-04-30 Kentaro Hara <[email protected]>
+
+ Unreviewed. Fix test crashes in Win/Linux debug builds.
+
+ * bindings/v8/V8LazyEventListener.cpp:
+ (WebCore::V8LazyEventListener::V8LazyEventListener):
+ (WebCore::V8LazyEventListener::prepareListenerObject):
+ * bindings/v8/V8LazyEventListener.h:
+ (V8LazyEventListener):
+
2012-04-30 Tommy Widenflycht <[email protected]>
MediaStream API: Change LocalMediaStream::stop to be synchronous
Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp (115651 => 115652)
--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-04-30 17:45:00 UTC (rev 115651)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp 2012-04-30 17:53:53 UTC (rev 115652)
@@ -59,9 +59,6 @@
, m_sourceURL(sourceURL)
, m_node(node)
, m_position(position)
-#ifndef NDEBUG
- , m_prepared(false)
-#endif
{
}
@@ -219,15 +216,11 @@
wrappedFunction->SetName(v8::String::New(fromWebCoreString(m_functionName), m_functionName.length()));
- // FIXME: Remove m_prepared and the following comment-outs.
+ // FIXME: Remove the following comment-outs.
// See https://bugs.webkit.org/show_bug.cgi?id=85152 for more details.
-#ifndef NDEBUG
- // Checks if the second parsing never happens. Currently the second parsing can happen
- // in a popup window.
- ASSERT(!m_prepared);
- m_prepared = true;
-#endif
- // Comments out the following code since the second parsing can happen.
+ //
+ // For the time being, we comment out the following code since the
+ // second parsing can happen.
// // Since we only parse once, there's no need to keep data used for parsing around anymore.
// m_functionName = String();
// m_code = String();
Modified: trunk/Source/WebCore/bindings/v8/V8LazyEventListener.h (115651 => 115652)
--- trunk/Source/WebCore/bindings/v8/V8LazyEventListener.h 2012-04-30 17:45:00 UTC (rev 115651)
+++ trunk/Source/WebCore/bindings/v8/V8LazyEventListener.h 2012-04-30 17:53:53 UTC (rev 115652)
@@ -75,9 +75,6 @@
String m_sourceURL;
Node* m_node;
TextPosition m_position;
-#ifndef NDEBUG
- bool m_prepared;
-#endif
};
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
