Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 651c2a2cdcac1fb8bde41eb878db83fbf0525f31
https://github.com/WebKit/WebKit/commit/651c2a2cdcac1fb8bde41eb878db83fbf0525f31
Author: Issac Roy <[email protected]>
Date: 2026-08-28 (Fri, 28 Aug 2026)
Changed paths:
M Tools/CISupport/ews-build/results_db.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[EWS] Activate flaky test verdicts
https://bugs.webkit.org/show_bug.cgi?id=322866
rdar://186115028
Reviewed by Aakash Jain.
EWS computes a flakiness verdict for every layout-test failure it cannot
explain as a pre-existing failure, then throws it away:
`SHOULD_IGNORE_FLAKY_TESTS` is `False`, so a convicted test stays in
`failing_tests_filtered` and still blames the pull request. A recent
48-hour window produced 1292 such convictions across 4737 builds.
Act on them. `INCLUDED_FLAKY_VERDICTS` names the verdicts a queue ignores
a failure for, one entry per verdict rather than one boolean for all
three, so a verdict can be withdrawn from production without reverting
the read path. All three are included. The results-db log reports
`Ignored` and `Would have ignored` separately and counts the tests each
applied to, not every conviction.
`AUTHORS_FOR_DIRTY_TREE_FLAKE` rises from 1 to 2. A build's first run
reports its own flakes before its re-run reads them back, so a
`DirtyTree` conviction could rest on one author's stack of pull requests
excusing its own regression. Requiring a second author makes the evidence
independent of the change under test.
* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase):
(ResultsDatabase._is_intra_build_flake):
(ResultsDatabase._is_inter_build_flake):
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests):
(RunWebKitTests.filter_failures_using_results_db):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFilterLayoutTestFailuresUsingResultsDB.test_a_verdict_in_the_included_set_removes_the_failure):
(TestFilterLayoutTestFailuresUsingResultsDB):
(TestFilterLayoutTestFailuresUsingResultsDB.test_a_verdict_outside_the_included_set_is_recorded_without_ignoring_the_failure):
(TestFilterLayoutTestFailuresUsingResultsDB.test_the_ignore_message_covers_both_categories):
(TestFilterLayoutTestFailuresUsingResultsDB.test_a_flaky_verdict_is_recorded_without_ignoring_the_failure):
Deleted.
Canonical link: https://commits.webkit.org/320087@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
