Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0da994ab75f665dc639506bf7d920ba64fd5c26c
https://github.com/WebKit/WebKit/commit/0da994ab75f665dc639506bf7d920ba64fd5c26c
Author: Antoine Quint <[email protected]>
Date: 2026-08-31 (Mon, 31 Aug 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt
M Source/WebCore/animation/StyleOriginatedTimelinesController.cpp
M Source/WebCore/animation/WebAnimationUtilities.cpp
M Source/WebCore/animation/WebAnimationUtilities.h
Log Message:
-----------
[scroll-animations] match style-originated timelines globally
https://bugs.webkit.org/show_bug.cgi?id=322989
rdar://186261285
Reviewed by Tim Nguyen.
The CSS WG updated style-originated timelines to match globally by default [0],
allowing timelines
to be defined outside of the target's hierarchy or that of an element with a
`timeline-scope`
property.
We update our matching code to no longer assume timelines must be contained
within the target's
hierarchy and ensure that when a `timeline-scope` property is not set for a
given timeline's name
we use global document ordering to determine which timeline to match.
To that end we rename
`compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder()`
to `compareStyleablePositionsInDocumentTreeOrder()` and make it public.
This fixes many of the failures in the WPT test
`scroll-animations/css/timeline-scope.html` that
were introduced due to the relevant WPT changes [1] but some more specific
issues will be fixed
with followup patches.
[0] https://github.com/w3c/csswg-drafts/pull/13624
[1] https://github.com/web-platform-tests/wpt/pull/61776
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::determineTreeOrder):
(WebCore::StyleOriginatedTimelinesController::determineTimelineForElement):
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::compareStyleablePositionsInDocumentTreeOrder):
(WebCore::compareCSSTransitions):
(WebCore::compareCSSAnimations):
(WebCore::compareStyleOriginatedAnimationEvents):
(WebCore::compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder):
Deleted.
* Source/WebCore/animation/WebAnimationUtilities.h:
Canonical link: https://commits.webkit.org/320183@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
