Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 13ea4c03c17ffc75e47cd08d073e1f203588885f
https://github.com/WebKit/WebKit/commit/13ea4c03c17ffc75e47cd08d073e1f203588885f
Author: Cameron McCormack <[email protected]>
Date: 2026-08-31 (Mon, 31 Aug 2026)
Changed paths:
M LayoutTests/fast/canvas/webgl/oes-texture-float-linear-expected.txt
M
LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js
M LayoutTests/platform/mac/TestExpectations
Log Message:
-----------
Tolerate generateMipmap failing for float textures in
oes-texture-float-linear.html.
https://bugs.webkit.org/show_bug.cgi?id=322957
rdar://186229937
Reviewed by Dan Glastonbury.
Enabling OES_texture_float implicitly enables WEBGL_color_buffer_float, which
makes ANGLE promote RGBA/FLOAT uploads to the sized internal format RGBA32F. A
sized format must be both color-renderable and filterable to be mipmapped, and
RGBA32F is not filterable until OES_texture_float_linear is enabled, so
generateMipmap returns INVALID_OPERATION. The test called generateMipmap
unconditionally, ignored the error, and then attributed it to the following
draw.
Khronos rewrote the upstream test in 2019 to skip the rest of the case when
generateMipmap fails, calling that legal. This is a WebKit-local fork frozen at
its 2013 import, so it never picked that up. The maintained conformance version
of the same test already passes on every mac configuration.
The console messages the old baseline expected came from WebKit's pre-ANGLE
backend, deleted in 254947@main, and are correctly absent now.
* LayoutTests/fast/canvas/webgl/oes-texture-float-linear-expected.txt:
*
LayoutTests/fast/canvas/webgl/resources/oes-texture-float-and-half-float-linear.js:
* LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/320188@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
