Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d00164ce4f40139d2e52e225aeeb8cc529bdaf6
      
https://github.com/WebKit/WebKit/commit/1d00164ce4f40139d2e52e225aeeb8cc529bdaf6
  Author: Zak Ridouh <[email protected]>
  Date:   2026-09-01 (Tue, 01 Sep 2026)

  Changed paths:
    M Source/WebKitLegacy/PlatformCocoa.cmake

  Log Message:
  -----------
  [CMake] WebKitLegacy should not link libPAL.a
https://bugs.webkit.org/show_bug.cgi?id=322622
rdar://185923994

Reviewed by Elliott Williams.

WebCore force-loads libPAL.a and re-exports it, so listing the static PAL
target in WebKitLegacy_PRIVATE_LIBRARIES gave WebKitLegacy.framework a
second copy of every PAL object it referenced thus duplicating PAL's state,
not just its code, including soft-link class singletons and isoheap
s_heapRef/s_heapSpec pairs.

WebKitLegacy_FRAMEWORKS already lists PAL, which resolves to WebCore, and
WebKit.framework relies on the same thing. Headers are unaffected:
WebKitLegacy_PRIVATE_INCLUDE_DIRECTORIES lists PAL_FRAMEWORK_HEADERS_DIR.
Xcode's WebKitLegacy.xcconfig never linked libPAL.a either.

Matches Xcode behavior, and saves ~200KB of binary size.

* Source/WebKitLegacy/PlatformCocoa.cmake:

Canonical link: https://commits.webkit.org/320243@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to