Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c0a49688cb186d90984cc82b3b45259088e1cf77
https://github.com/WebKit/WebKit/commit/c0a49688cb186d90984cc82b3b45259088e1cf77
Author: Alan Baradlay <[email protected]>
Date: 2026-09-07 (Mon, 07 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/fast/lists/008-expected.txt
M LayoutTests/platform/glib/fast/lists/008-vertical-expected.txt
M LayoutTests/platform/ios/fast/lists/008-expected.txt
M LayoutTests/platform/ios/fast/lists/008-vertical-expected.txt
M LayoutTests/platform/mac/fast/lists/008-expected.txt
M LayoutTests/platform/mac/fast/lists/008-vertical-expected.txt
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp
M Source/WebCore/layout/layouttree/LayoutElementBox.cpp
M Source/WebCore/layout/layouttree/LayoutElementBox.h
M Source/WebCore/rendering/RenderListOutsideMarker.cpp
M Source/WebCore/rendering/RenderListOutsideMarker.h
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
Log Message:
-----------
[list-marker] Give every outside list marker its content as renderers instead
of hand-drawing the text and the image
https://bugs.webkit.org/show_bug.cgi?id=323502
rdar://problem/186741639
Reviewed by Antti Koivisto.
The outside marker already held its content as renderers when the ::marker had
a content property, right to left
text or a synthesized glyph. Build them for the rest too, so one path measures,
lays out and paints every marker.
The render tree dump leaves the marker's renderers out: its own line already
carries the text.
* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/fast/lists/008-expected.txt:
* LayoutTests/platform/glib/fast/lists/008-vertical-expected.txt:
* LayoutTests/platform/ios/fast/lists/008-expected.txt:
* LayoutTests/platform/ios/fast/lists/008-vertical-expected.txt:
* LayoutTests/platform/mac/fast/lists/008-expected.txt:
* LayoutTests/platform/mac/fast/lists/008-vertical-expected.txt:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp:
(WebCore::LayoutIntegration::isListMarkerImage):
(WebCore::LayoutIntegration::BoxTreeUpdater::createLayoutBox):
(WebCore::LayoutIntegration::BoxTreeUpdater::updateStyle):
(WebCore::LayoutIntegration::calculateListMarkerAttribute): Deleted.
* Source/WebCore/layout/layouttree/LayoutElementBox.cpp:
(WebCore::Layout::ElementBox::ElementBox):
* Source/WebCore/layout/layouttree/LayoutElementBox.h:
(WebCore::Layout::ElementBox::setIsListMarkerImage):
(WebCore::Layout::ElementBox::isListMarkerImage const):
(WebCore::Layout::ElementBox::setListMarkerAttributes): Deleted.
* Source/WebCore/rendering/RenderListOutsideMarker.cpp:
(WebCore::RenderListOutsideMarker::paint):
(WebCore::RenderListOutsideMarker::layout):
(WebCore::RenderListOutsideMarker::layoutContentContainer):
(WebCore::RenderListOutsideMarker::updateContent):
(WebCore::RenderListOutsideMarker::setContentContainerImageSize):
(WebCore::RenderListOutsideMarker::computeIntrinsicLogicalWidthContributions):
(WebCore::RenderListOutsideMarker::updateInlineMargins):
(WebCore::symbolsContainStrongDirectionalityText): Deleted.
(WebCore::counterStyleChainHasStrongDirectionalitySymbols): Deleted.
(WebCore::RenderListOutsideMarker::textNeedsBidiResolution): Deleted.
(WebCore::RenderListOutsideMarker::needsContentContainer): Deleted.
(WebCore::textRunForContent): Deleted.
(WebCore::RenderListOutsideMarker::relativeMarkerRect): Deleted.
(WebCore::RenderListOutsideMarker::counterStyle): Deleted.
* Source/WebCore/rendering/RenderListOutsideMarker.h:
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::write):
* Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:
(WebCore::RenderTreeBuilder::List::updateItemMarker):
(WebCore::RenderTreeBuilder::List::buildMarkerContentRenderers):
Canonical link: https://commits.webkit.org/320626@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
