Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3f39fb99f98226f668f7e04a1287564a606a1a5a
https://github.com/WebKit/WebKit/commit/3f39fb99f98226f668f7e04a1287564a606a1a5a
Author: Alan Baradlay <[email protected]>
Date: 2026-09-08 (Tue, 08 Sep 2026)
Changed paths:
M Source/WebCore/rendering/RenderListItem.cpp
M Source/WebCore/rendering/RenderListOutsideMarker.cpp
M Source/WebCore/rendering/RenderListOutsideMarker.h
Log Message:
-----------
[cleanup] Drop RenderListOutsideMarker::m_image, the marker box's copy of the
list-style-image its style already holds
https://bugs.webkit.org/show_bug.cgi?id=323549
rdar://problem/186794793
Reviewed by Antti Koivisto.
The member held what style().listStyleImage() holds. Ask style for it: whether
the marker shows an image, and
which image it resolves the size from, now go through listMarkerImage(), which
is the name the two open-coded
copies of "a list-style-image that loaded" get. The marker is still the image's
client so that it hears about
the image loading and about it failing to load, and that registration diffs the
old style against the new one
the way RenderElement::updateFillImages does. It reads the style image
unfiltered, since a marker whose image
failed has to hear about it to become a text marker.
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerText const):
* Source/WebCore/rendering/RenderListOutsideMarker.cpp:
(WebCore::RenderListOutsideMarker::willBeDestroyed):
(WebCore::RenderListOutsideMarker::styleDidChange):
(WebCore::RenderListOutsideMarker::isImage const):
(WebCore::RenderListOutsideMarker::imageChanged):
(WebCore::RenderListOutsideMarker::updateContent):
(WebCore::listMarkerImage):
(WebCore::listMarkerSynthesizesGlyph):
(WebCore::listMarkerShowsImage): Deleted.
* Source/WebCore/rendering/RenderListOutsideMarker.h:
Canonical link: https://commits.webkit.org/320672@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
